Remove CRLF from folded HTTP header values#3654
Open
giorka wants to merge 1 commit into
Open
Conversation
Refactor header value processing to remove CRLF sequences and trim whitespace.
aionxnetwork
approved these changes
May 24, 2026
Contributor
|
The pull request looks correct, but HTTP header line folding is obsolete and deprecated for the last 12 years as stated in the RFC 7230. Therefore, there are no reasons to support it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already a TODO to remove
"\r\n"from folded header values. Normalize folded HTTP headers in-place by replacing CRLF + whitespace sequences with a single space before processing the header value.Reference: RFC 7230