fix: implement real stale-binary detection in launch.bat (#17)#22
Merged
Conversation
launch.bat advertised "stale-binary detection" but computed EXE_TS/SRC_TS/NOW and never compared them — a no-op, so a stale exe launched silently. - scripts/check_stale.ps1: compares LastWriteTimeUtc of hyperwall.py vs hyperwall.exe; exit 2 = stale (source newer), exit 0 = current/missing. - launch.bat: calls it and prints a warning + 3s abort window when stale, replacing the dead timestamp vars. Non-blocking (warns, still launches). - tests/test_check_stale.ps1: fixture-based test of all four exit paths (fresh, stale, missing-exe, missing-src), wired into the windows-build CI job so the logic is actually verified on a real Windows runner. Closes #17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
launch.batclaimed 'stale-binary detection' but computed timestamps and never compared them — a stale exe launched silently.LastWriteTimeUtcofhyperwall.pyvshyperwall.exe; exit 2 = stale, exit 0 = current/missing.windows-buildCI job so it's verified on a real Windows runner, not by inspection.Closes #17.