feat: Identity Unification — v10, versionless exe + drift guard (Epic 1, #6)#12
Merged
Merged
Conversation
#6) Single source of version truth and a versionless executable so future bumps never again break G-Sync isolation (which is gated on the exe basename). - __init__.py: __version__ = "10.0.0" + derived VERSION_SHORT (bump = 1 line) - emby.py / wizard.py: User-Agent, Emby auth Version, window titles derive from VERSION_SHORT (no more hardcoded "9.0") - nvidia.py: G-Sync isolation decoupled from literal "hyperwall_v8.exe" — now _is_isolated_launch() matches a "hyperwall*.exe" prefix or HYPERWALL_ISOLATED=1 - constants.py: LAUNCHER_EXE / NV_SENTINEL versionless - build.bat / build.ps1 / bootstrap.ps1 (renamed from bootstrap_v8.ps1) / launch.bat: emit and launch "hyperwall.exe" - hyperwall.nip: NVIDIA profile now targets hyperwall.exe (load-bearing — the profile matches on exe basename) - tests: bump version assert; add test_08_no_versioned_exe_literals to fail CI if hyperwall_v<N> / hardcoded-version drift ever returns - .github/workflows/repo-guards.yml: run guards on push + PR - README / .gitignore / module docstrings updated Validation: py_compile clean, 8/8 repo guards pass, VERSION_SHORT=10.0 and exe basename resolve verified. PyInstaller build + live G-Sync check pending on skyhawk (Windows). Refs #6
test_01 only skipped on a missing PyQt6; in a bare CI runner 'requests' was the first missing module, so the guard re-raised and failed the build. Skip gracefully on any of PyQt6/requests/flask/mpv (this is an import smoke test, not a dependency check). Fixes the CI failure on the Epic 1 PR.
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Epic 1: Identity Unification (closes #6) — the foundation for the v10 milestone.
Why
The package said v9 but the binary was
hyperwall_v8.exeeverywhere, and G-Sync isolation was hard-gated on that exact basename (nvidia.py:85). Thev8/9.0string was duplicated across ~15 sites. Bumping the version would have silently disabled G-Sync isolation. This PR makes the version a single source of truth and the exe versionless, so no future bump can ever break isolation again.What changed
__init__.py—__version__ = "10.0.0"+ derivedVERSION_SHORT. A version bump now touches exactly one line.emby.py/wizard.py— User-Agent, Emby authVersion, and window/wizard titles derive fromVERSION_SHORT(no more hardcoded"9.0").nvidia.py— new_is_isolated_launch()gates G-Sync isolation on ahyperwall*.exeprefix orHYPERWALL_ISOLATED=1, replacing the two literal"hyperwall_v8.exe"checks.constants.py—LAUNCHER_EXE→hyperwall.exe,NV_SENTINEL→.hyperwall_nvprofile.sentinel.build.bat,build.ps1,bootstrap.ps1(renamed frombootstrap_v8.ps1), andlaunch.batall emit/launchhyperwall.exe.hyperwall.nip—hyperwall.exe. Without this, isolation wouldn't apply to the renamed binary.test_08_no_versioned_exe_literals, which fails if anyhyperwall_v<N>/ hardcoded-HyperWall/<x.y>literal ever resurfaces. New.github/workflows/repo-guards.ymlruns the guards on push + PR.Validation (Linux)
py_compileclean across all modules.hyperwall_v8literal).__version__=10.0.0,VERSION_SHORT=10.0,LAUNCHER_EXEbasename =hyperwall.exe.Per the project's own guardrail (don't assume a fix works from code inspection alone):
build.bat→ produceshyperwall.exe.hyperwall.exein NPI.static=truepath unchanged, but verify).Milestone: v10 · Part of the roadmap in #5.