fix(macos): use correct display for coordinate conversion #1159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded main display usage with current window's display for coordinate conversion functions. This ensures proper positioning when working with multiple displays. Add helper function `display_of_screen` to safely get CGDisplay from NSScreen. Update all coordinate-related functions to accept display parameter.
Member
|
thanks for the PR! can you also add a small changefile like 92e2220#diff-4ef786f1a6a3552edc00a2a68d6d97d40cdadd18dbac5efe49843bd4f328839a please? :) |
Contributor
Package Changes Through bd79646There are 1 changes which include tao with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Author
@FabianLars Change file added. :D |
Author
|
ping @FabianLars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded main display usage with current window's display for coordinate conversion functions. This ensures proper positioning when working with multiple displays.
Add helper function
display_of_screento safely getCGDisplayfromNSScreen. Update all coordinate-related functions to accept display parameter.