@W-21474807 Group get-datasource-metadata fields by logicalTableId#255
Merged
joeconstantino merged 11 commits intomainfrom Mar 16, 2026
Merged
@W-21474807 Group get-datasource-metadata fields by logicalTableId#255joeconstantino merged 11 commits intomainfrom
joeconstantino merged 11 commits intomainfrom
Conversation
Contributor
Author
|
I'm going to wait on merging this actually. Changing the approach. |
stephendeoca
approved these changes
Mar 11, 2026
Reduce metadata payload redundancy by replacing duplicate table mapping output with grouped fields entries (`logicalTableId` + `columns`). Keep calc/null grouping explicit while removing sourceTable from the response contract. Made-with: Cursor
joeconstantino
changed the title
joeconstantino
changed the title
Update e2e and eval metadata tests to flatten grouped `fields` entries (`logicalTableId` + `columns`) before asserting column names. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourceTablefrom get-datasource-metadata field payloadsfieldsto grouped entries:{ logicalTableId, columns[] }withlogicalTableId: nullsupported1.17.13Test plan
npm run lint -- \"src/tools/getDatasourceMetadata/**/*.ts\"npm test -- getDatasourceMetadata.test.tsget-datasource-metadatafor datasource3f8f54d4-1587-4b5a-b6d7-4a1b37887122and verify groupedfieldsGUS