Update limit #83
Merged
Update limit #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug #1: Fix revision increment gap in mysql.rs - Changed revision increment logic to prevent gaps - Both tombstone and active rows now use same revision (current+1) - Maintains sequential revision tracking without N+2 jumps Bug #2: Fix cross-watcher MOVE broadcast in rename.rs - Use server IDs instead of client IDs for cross-watcher moves - Ensures other devices can properly locate moved files - Fixes synchronization failure across devices All tests passing (17/17). Ready for production deployment.
- Convert String::from_utf8_lossy unwrap to proper error handling - Return StorageError::Database if plain_path is missing - Prevents potential production panic during encryption migration Phase 1B: unwrap removal (1/37)
- mysql_file.rs: Use match pattern for row_opt instead of is_none() + unwrap() - mysql_quota.rs: Replace unwrap() with expect() for valid date calculations - server/service.rs: Replace unwrap() with expect() for midnight time Phase 1B: unwrap removal (2-8/37)
- version_service.rs: Use map_or() instead of is_some()+unwrap() pattern - usage_service.rs: Use if-let for safe downcast in warning update Phase 1B: unwrap removal (9-10/37)
- Change decrypt_text parameter from Vec<u8> to &[u8] - Remove 20 unnecessary clone() calls in mysql_file.rs - Reduces heap allocations during file decryption operations Phase 3: Clone optimization (1/n)
Resolved conflicts: - proto/sync.proto: Keep overwrite field (field 14) - src/handlers/file/rename.rs: Keep server ID fix for cross-watcher moves - src/storage/mysql.rs: Keep revision+2 for UNIQUE constraint compliance 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add InvalidateKeyId RPC for key lifecycle management - Block downloads for files with invalidated keys (KEY_INVALIDATED error) - Add error_code field to DownloadFileResponse - Add mysql_key.rs storage layer with idempotent invalidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.