-
Notifications
You must be signed in to change notification settings - Fork 1k
Integrate otel-cpp library with the build system #4990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: otel
Are you sure you want to change the base?
Conversation
Signed-off-by: Wazir Ahmed <[email protected]>
Signed-off-by: Wazir Ahmed <[email protected]>
Signed-off-by: Wazir Ahmed <[email protected]>
Signed-off-by: Wazir Ahmed <[email protected]>
Signed-off-by: Wazir Ahmed <[email protected]>
Signed-off-by: Wazir Ahmed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @wazir-ahmed, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the OpenTelemetry C++ client library and its required dependencies (Abseil, Protobuf, JSON) into the project's build infrastructure. It updates the Makefiles to fetch, build, and install these new dependencies locally, and adjusts the compilation and linking flags across the project to incorporate them. Additionally, it refactors the include paths for the JSON library to align with a standard installation structure.
Highlights
- OpenTelemetry Integration: Integrated the OpenTelemetry C++ client library (otel-cpp) into the project's build system.
- Dependency Management: Added build rules for OpenTelemetry and its core dependencies (Abseil, Protobuf, JSON) within the
deps/Makefile
. - Build System Updates: Modified main, library, source, and test Makefiles to include necessary paths and link against the newly added OpenTelemetry and dependency libraries.
- Include Path Refactoring: Updated numerous source and header files to use standard include paths (e.g.,
nlohmann/json.hpp
) for the JSON library, reflecting its installation into a designated include directory.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request integrates the OpenTelemetry C++ library and its dependencies (Abseil, Protobuf, updated cURL, nlohmann/json) into the build system. Key changes involve updating deps/Makefile
to download, build, and install these libraries, modifying src/Makefile
and lib/Makefile
to include new header and library paths, and updating C++ source files to use the new include path for nlohmann/json.
Several potential issues were identified, primarily concerning the directory path assumptions for extracted tarballs in deps/Makefile
, a possible typo in src/Makefile
affecting cURL include paths on Linux, and a missing cleanup step in deps/Makefile
. The changes to C++ include paths for the JSON library are generally good, assuming the dependency is correctly built and its headers are placed as expected.
Closes #4985.