[Turbo] Fix SplObjectStorage::attach deprecation in Doctrine Broadcast listener
#3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
SplObjectStorage::attach with array access in Doctrine Broadcast listenerSplObjectStorage::attach deprecation in Doctrine Broadcast listener
GromNaN
commented
Jan 7, 2026
|
|
||
| if ($options = $this->broadcastedClasses[$class]) { | ||
| if ('createdEntities' !== $property) { | ||
| if ($this->createdEntities !== $objectStorage) { |
Member
Author
There was a problem hiding this comment.
Using object identity instead of string comparison. The object in $this->createdEntities can't be replaced after it's passed to call storeEntitiesToPublish.
GromNaN
force-pushed
the
php85-objectstorage-attach
branch
2 times, most recently
from
3705ed9 to
f2d05fd
Compare
Member
Author
|
PHP 8.4 issue related to symfony/panther#688 |
Member
|
Other checks are failing (e.g. https://github.com/symfony/ux/actions/runs/20796034910/job/59729700255?pr=3273) but that's not related to your PR, I didn't have time to investigate yet (help welcome 🙏🏻 ) |
Kocal
approved these changes
Jan 7, 2026
carsonbot
added
Status: Reviewed
GromNaN
commented
Jan 8, 2026
…t listener The method is deprecated in PHP 8.5 Also refactor to avoid dynamic property access and help static analysis
GromNaN
force-pushed
the
php85-objectstorage-attach
branch
from
f2d05fd to
de466ce
Compare
Member
|
You can also ignore "Functional Tests" jobs, IIRC they are flakies, sometimes they work, sometimes they don't. We need to take time to investigate |
Member
|
Thank you @GromNaN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
SplObjectStorage::attachis deprecated in PHP 8.5.I refactored the method to avoid dynamic property access, which should help the static analysis.