Skip to content

[6.2] AST: Diagnose unrecognized platforms as errors with CustomAvailability enabled #82083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from

Conversation

tshortli
Copy link
Contributor

@tshortli tshortli commented Jun 7, 2025

  • Explanation: When the CustomAvailability experimental feature is enabled, make it an error to specify an unrecognized availability domain name. Also, add these diagnostics to a diagnostic group so that developers can control their behavior when they are warnings.
  • Scope: Changes type-checker behavior when CustomAvailability is enabled.
  • Issue/Radar: rdar://152741624
  • Original PR: AST: Diagnose unrecognized platforms as errors with CustomAvailability enabled. #82075
  • Risk: Low. CustomAvailability should not be enabled yet in any existing projects, and even if it were those projects would also have to contain references to non-existent availability domains in order to be rejected.
  • Testing: Updated compiler test cases.
  • Reviewer:

…y enabled.

When the CustomAvailability experimental feature is enabled, make it an error
to specify an unrecognized availability domain name. Also, add these
diagnostics to a diagnostic group so that developers can control their behavior
when they are warnings.

Resolves rdar://152741624.
@tshortli tshortli requested a review from a team as a code owner June 7, 2025 05:45
@tshortli tshortli changed the title AST: Diagnose unrecognized platforms as errors with CustomAvailability enabled [6.2] AST: Diagnose unrecognized platforms as errors with CustomAvailability enabled Jun 7, 2025
@tshortli
Copy link
Contributor Author

tshortli commented Jun 7, 2025

@swift-ci please test

@tshortli
Copy link
Contributor Author

tshortli commented Jun 7, 2025

swiftlang/llvm-project#10805

@swift-ci please test macOS

@tshortli
Copy link
Contributor Author

tshortli commented Jun 8, 2025

@swift-ci please test macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant