Skip to content

[6.2][Indexing] Don't verify mangling of USRs #82054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 6, 2025

  • Explanation: Verifying USR mangling adds ~30% overhead to indexing times. We don’t verify the mangled names that we use for code generation and the USRs we create are less correctness-critical. Save those 30% when asserts are disabled.
  • Scope: Indexing
  • Issue: n/a
  • Original PR: [Indexing] Don't verify mangling of USRs #81941
  • Risk: Very low, this disables a check that might have crashed the compiler
  • Testing: Builds and passes tests
  • Reviewer: @bnbarham @hamishknight

Verifying USR mangling adds ~30% overhead to indexing times. Since an incorrect USR mangling doesn't result in a correctness issue at the same level as a miscompile, save those 30% in non-assert builds.
@ahoppen ahoppen requested a review from a team as a code owner June 6, 2025 06:41
@ahoppen
Copy link
Member Author

ahoppen commented Jun 6, 2025

@swift-ci Please test

@ahoppen ahoppen merged commit 3780aba into swiftlang:release/6.2 Jun 10, 2025
5 checks passed
@ahoppen ahoppen deleted the 6.2/dont-verify-mangle branch June 10, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants