[6.2][Indexing] Don't verify mangling of USRs #82054
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ahoppen
commented
Jun 6, 2025
ahoppen
commented
- Explanation: Verifying USR mangling adds ~30% overhead to indexing times. We don’t verify the mangled names that we use for code generation and the USRs we create are less correctness-critical. Save those 30% when asserts are disabled.
- Scope: Indexing
- Issue: n/a
- Original PR: [Indexing] Don't verify mangling of USRs #81941
- Risk: Very low, this disables a check that might have crashed the compiler
- Testing: Builds and passes tests
- Reviewer: @bnbarham @hamishknight
Verifying USR mangling adds ~30% overhead to indexing times. Since an incorrect USR mangling doesn't result in a correctness issue at the same level as a miscompile, save those 30% in non-assert builds.
|
@swift-ci Please test |
bnbarham
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.