Skip to content

[ST-0020] Promote SourceLocation.filePath to API. #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
grynspan wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[ST-0020] Promote SourceLocation.filePath to API. #1472

grynspan wants to merge 19 commits into from

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 6, 2026 •
edited
Loading

This PR formally implements the changes proposed in ST-0020.

Resolves rdar://152999195.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added this to the Swift 6.3.0 milestone Jan 6, 2026
@grynspan grynspan self-assigned this Jan 6, 2026
@grynspan grynspan added tools integration 🛠️ Integration of swift-testing into tools/IDEs public-api Affects public API issue-handling Related to Issue handling within the testing library labels Jan 6, 2026
grynspan added 16 commits January 6, 2026 15:47
@grynspan
Add EncodedSourceLocation
176046e
@grynspan
Wrap basename() because it's redefined on Linux
244a9fc
@grynspan
Support OpenBSD (sigh)
19ddbaa
@grynspan
Don't use basename(3) or Win32 API, it's just too inconsistent
99a732b
@grynspan
do, not closure
e11b4b1
@grynspan
Relax constraints on EncodedSourceLocation, adjust JSON.md, don't all…
c2ecbcf 
…ow missing fileID in SourceLocation:Codable (which should not be concerned with non-Swift data sources)
@grynspan
Update <version> in JSON.md
d85ead4
@grynspan
typo
c2c209b
@grynspan
Don't encode synthesized file IDs to JSON stream
d237cc0
@grynspan
Fix failing test
559285e
@grynspan
Merge branch 'main' into jgrynspan/promote-sourcelocation-filepath-to…
dad0fe0 
…-api
@grynspan
Add proposal reference to JSON.md
b459d4a
@grynspan
Update #_sourceLocation comment
a3b3464
@grynspan
Merge branch 'main' into jgrynspan/promote-sourcelocation-filepath-to…
083daae 
…-api
@grynspan
Merge branch 'main' into jgrynspan/promote-sourcelocation-filepath-to…
6ff0433 
…-api
@grynspan
Remove stray imports
37780a9
@grynspan grynspan changed the title Promote SourceLocation.filePath to API. [ST-0020] Promote SourceLocation.filePath to API. Jan 27, 2026
@grynspan grynspan marked this pull request as ready for review January 28, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen is a code owner

@harlanhaskins harlanhaskins Awaiting requested review from harlanhaskins harlanhaskins is a code owner

Assignees

@grynspan grynspan

Labels

issue-handling Related to Issue handling within the testing library public-api Affects public API tools integration 🛠️ Integration of swift-testing into tools/IDEs

Projects

None yet

Milestone

Swift 6.4.0 (main)

Development

Successfully merging this pull request may close these issues.

1 participant

@grynspan