Remove ValueGenerics feature from swift-syntax

CodeGeneration/Sources/SyntaxSupport/ExperimentalFeatures.swift

@@ -19,7 +19,6 @@ public enum ExperimentalFeature: String, CaseIterable {
   case nonescapableTypes
   case trailingComma
   case coroutineAccessors
-  case valueGenerics
   case abiAttribute
   case keypathWithMethodMembers
   case oldOwnershipOperatorSpellings
@@ -40,8 +39,6 @@ public enum ExperimentalFeature: String, CaseIterable {
       return "TrailingComma"
     case .coroutineAccessors:
       return "CoroutineAccessors"
-    case .valueGenerics:
-      return "ValueGenerics"
     case .abiAttribute:
       return "ABIAttribute"
     case .keypathWithMethodMembers:
@@ -68,8 +65,6 @@ public enum ExperimentalFeature: String, CaseIterable {
       return "trailing commas"
     case .coroutineAccessors:
       return "coroutine accessors"
-    case .valueGenerics:
-      return "value generics"
     case .abiAttribute:
       return "@abi attribute"
     case .keypathWithMethodMembers:

CodeGeneration/Sources/SyntaxSupport/GenericNodes.swift

@@ -341,8 +341,7 @@ public let GENERIC_NODES: [Node] = [
           ),
           Child(
             name: "expr",
-            kind: .node(kind: .expr),
-            experimentalFeature: .valueGenerics
+            kind: .node(kind: .expr)
           ),
         ]),
         nameForDiagnostics: "left-hand type",
@@ -362,8 +361,7 @@ public let GENERIC_NODES: [Node] = [
           ),
           Child(
             name: "expr",
-            kind: .node(kind: .expr),
-            experimentalFeature: .valueGenerics
+            kind: .node(kind: .expr)
           ),
         ]),
         nameForDiagnostics: "right-hand type",

CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift

@@ -264,8 +264,7 @@ public let TYPE_NODES: [Node] = [
           ),
           Child(
             name: "expr",
-            kind: .node(kind: .expr),
-            experimentalFeature: .valueGenerics
+            kind: .node(kind: .expr)
           ),
         ]),
         documentation:

Sources/SwiftParser/Types.swift

@@ -1233,12 +1233,6 @@ extension Parser {
 
 extension Parser {
   mutating func parseValueType() -> RawExprSyntax? {
-    // If the 'ValueGenerics' experimental feature hasn't been added, then don't
-    // attempt to parse values as types.
-    guard self.experimentalFeatures.contains(.valueGenerics) else {
-      return nil
-    }
-
     // Eat any '-' preceding integer literals.
     var minusSign: RawTokenSyntax? = nil
     if self.atContextualPunctuator("-"),

Tests/SwiftParserTest/ExpressionTypeTests.swift

@@ -138,7 +138,7 @@ final class ExpressionTypeTests: ParserTestCase {
         { ExprSyntax.parse(from: &$0) },
         substructure: IdentifierTypeSyntax(name: .identifier("X")),
         substructureAfterMarker: "1️⃣",
-        experimentalFeatures: [.inlineArrayTypeSugar, .valueGenerics],
+        experimentalFeatures: [.inlineArrayTypeSugar],
         line: line
       )
     }

Tests/SwiftParserTest/TypeTests.swift

@@ -541,7 +541,7 @@ final class TypeTests: ParserTestCase {
 
 final class InlineArrayTypeTests: ParserTestCase {
   override var experimentalFeatures: Parser.ExperimentalFeatures {
-    [.inlineArrayTypeSugar, .valueGenerics]
+    [.inlineArrayTypeSugar]
   }
 
   func testBasic() {

Tests/SwiftParserTest/ValueGenericsTests.swift

@@ -121,64 +121,55 @@ final class ValueGenericsTests: ParserTestCase {
       ],
       fixedSource: """
         let x: <#type#> = 123
-        """,
-      experimentalFeatures: .valueGenerics
+        """
     )
 
     assertParse(
       """
       let x: Generic<123>
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x: Generic<-123>
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x = Generic<123>.self
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x = Generic<-123>.self
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x = Generic<123, Int>.self
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x = Generic<-123, Int>.self
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x = Generic<Int, 123>.self
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       let x: Generic<Int, -123>.self
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
@@ -193,36 +184,31 @@ final class ValueGenericsTests: ParserTestCase {
       ],
       fixedSource: """
         typealias One = <#type#>1
-        """,
-      experimentalFeatures: .valueGenerics
+        """
     )
 
     assertParse(
       """
       extension Vector where N == 123 {}
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       extension Vector where 123 == N {}
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       extension Vector where N == -123 {}
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
       """
       extension Vector where -123 == N {}
-      """,
-      experimentalFeatures: .valueGenerics
+      """
     )
 
     assertParse(
@@ -240,8 +226,7 @@ final class ValueGenericsTests: ParserTestCase {
       ],
       fixedSource: """
         extension Vector where N: <#type#> 123 {}
-        """,
-      experimentalFeatures: .valueGenerics
+        """
     )
 
     assertParse(
@@ -259,8 +244,7 @@ final class ValueGenericsTests: ParserTestCase {
       ],
       fixedSource: """
         extension Vector where N: <#type#> -123 {}
-        """,
-      experimentalFeatures: .valueGenerics
+        """
     )
 
     assertParse(
@@ -274,8 +258,7 @@ final class ValueGenericsTests: ParserTestCase {
         DiagnosticSpec(
           message: "unexpected code ': N' in extension"
         ),
-      ],
-      experimentalFeatures: .valueGenerics
+      ]
     )
 
     assertParse(
@@ -289,8 +272,7 @@ final class ValueGenericsTests: ParserTestCase {
         DiagnosticSpec(
           message: "unexpected code ': N' in extension"
         ),
-      ],
-      experimentalFeatures: .valueGenerics
+      ]
     )
 
     assertParse(
@@ -302,8 +284,7 @@ final class ValueGenericsTests: ParserTestCase {
         ),
         DiagnosticSpec(message: "unexpected code '-1' in tuple type"),
       ],
-      fixedSource: "func foo() -> (<#type#>-1) X",
-      experimentalFeatures: [.valueGenerics]
+      fixedSource: "func foo() -> (<#type#>-1) X"
     )
   }
 }