-
Notifications
You must be signed in to change notification settings - Fork 237
Safe c interop #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Safe c interop #1071
Conversation
Have you considered putting this documentation in a docc catalog? |
I have not! I can't speak for Gábor and Egor, but I simply kept writing in the established file. What are the benefits of a docc catalog? I haven't contributed to the website before, so I don't really know how things work |
I remember the title was "Safe C++ and Swift interop" or something like that. If so we would also need to update it to include "C" as well. |
18b8c92
to
3605d1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some nits inline.
I don't have a strong opinion on the formatting, looks like all approaches have pros and cons :/ |
+1 for the 3rd option, despite horizontal scrolling. |
This adds documentation around __counted_by, __sized_by, API notes, and using lifetime attributes in C.
- replace [[clang::noescape]] syntax with __noescape (etc) - specify YAML syntax highlighting for YAML code blocks - consistently use "annotation" in favour of "attribute" - insert HTML table to enable code block in cells
This adds documentation around __counted_by, __sized_by, API notes, and using lifetime attributes in C.
This is stacked on top of #980.