FoundationEssentials,FoundationInternationalization: adjust for aliasing #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.
jmschonfeld
reviewed
Jun 9, 2025
| @@ -117,6 +117,7 @@ import Darwin | |||
| #elseif canImport(Android) | |||
| @preconcurrency import Android | |||
| import posix_filesystem.dirent | |||
| internal import _FoundationCShims | |||
There was a problem hiding this comment.
I don't think this file uses ICU - is this change required / relevant?
There was a problem hiding this comment.
Yes, it was needed to resolve some of the aliases.
There was a problem hiding this comment.
What are the functions that would break without this? While I can believe this change is needed for us to build, I'm surprised that it's because of the ICU change.
There was a problem hiding this comment.
S:/SourceCache/swift-project/swift-foundation/Sources/FoundationEssentials/FileManager/FileOperations+Enumeration.swift:390:37: error: property 'd_type' is not available due to missing import of defining module '_FoundationCShims' [#MemberImportVisibility]
118 | @preconcurrency import Android
119 | import posix_filesystem.dirent
120 | // internal import _FoundationCShims
| `- note: add import of module '_FoundationCShims'
121 | #elseif canImport(Glibc)
122 | @preconcurrency import Glibc
:
388 | if appendSlash {
389 | var isDirectory = false
390 | if dent.pointee.d_type == DT_DIR {
| `- error: property 'd_type' is not available due to missing import of defining module '_FoundationCShims' [#MemberImportVisibility]
391 | isDirectory = true
392 | } else if dent.pointee.d_type == DT_UNKNOWN {
itingliu
reviewed
Jun 11, 2025
| @@ -117,6 +117,7 @@ import Darwin | |||
| #elseif canImport(Android) | |||
| @preconcurrency import Android | |||
| import posix_filesystem.dirent | |||
| internal import _FoundationCShims | |||
There was a problem hiding this comment.
What are the functions that would break without this? While I can believe this change is needed for us to build, I'm surprised that it's because of the ICU change.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling symbol renaming in ICU, we import the functions as an alias. This causes the implicit nullability translation with C to disappear. Make these conversions explicit so that we can enable symbol renaming on non-Darwin platforms.