-
Notifications
You must be signed in to change notification settings - Fork 0
Update patches and build the compiler from the latest commits, not an older tag #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,15 @@ HOST_OS=ubuntu24.04 | |
source ./scripts/toolchain-vars.sh | ||
|
||
# Check-out and patch the sources | ||
if [[ "${BUILD_COMPILER}" != "1" ]]; then | ||
./scripts/fetch-source.sh --source-dir ${WORKDIR}/source --swift-tag ${SWIFT_TAG} | ||
else | ||
if [[ "${BUILD_SCHEME}" == "development" ]]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: instead of using environment variables, consider passing the e.g.: |
||
./scripts/fetch-source.sh --source-dir ${WORKDIR}/source --swift-scheme main | ||
else | ||
./scripts/fetch-source.sh --source-dir ${WORKDIR}/source --swift-scheme release/6.2 | ||
fi | ||
fi | ||
./patches/apply-patches.sh ${WORKDIR}/source/swift-project | ||
|
||
mkdir -p ${WORKDIR}/products | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking): instead of relying on an environment variable, consider making this more discoverable to using a command line argument to this script.
e.g.:
build-docker --build-compiler