Skip to content

drop node 18 and update exports syntax #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/better-moles-brake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@sveltejs/vite-plugin-svelte-inspector': major
'@sveltejs/vite-plugin-svelte': major
---

drop support for node18 and update exports map to use default export. cjs is supported via require esm in node 20.19+
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ jobs:
node: [22]
os: [ubuntu-latest, macos-latest, windows-latest]
include:
- node: 18
os: ubuntu-latest
- node: 20
os: ubuntu-latest
- node: 24
Expand Down
27 changes: 6 additions & 21 deletions docs/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,31 +181,16 @@ You should not use prebundleSvelteLibraries during build or for ssr, disable one

You really shouldn't. Svelte and Vite are esm first and the ecosystem is moving away from commonjs and so should you. Consider migrating to esm.

In case you have to, use dynamic import to load vite-plugin-svelte's esm code from cjs like this:
In case you have to, you can rely on node's "require esm" feature available in v20.19+

```diff
```js
// vite.config.cjs
const { defineConfig } = require('vite');
- const { svelte } = require('@sveltejs/vite-plugin-svelte');
module.exports = defineConfig(async ({ command, mode }) => {
+ const { svelte } = await import('@sveltejs/vite-plugin-svelte');
return {plugins:[svelte()]}
}
```
const { svelte, vitePreprocess } = require('@sveltejs/vite-plugin-svelte');

And for `vitePreprocess` you have to set up a lazy promise as top-level-await doesn't work for esm imports in cjs:

```diff
- const {vitePreprocess} = require('@sveltejs/vite-plugin-svelte')
+ const vitePreprocess = import('@sveltejs/vite-plugin-svelte').then(m => m.vitePreprocess())

module.exports = {
- preprocess: vitePreprocess()
+ preprocess: {
+ script:async (options) => (await vitePreprocess).script(options),
+ style:async (options) => (await vitePreprocess).style(options),
+ }
}
module.exports = defineConfig({
plugins: [svelte({ preprocess: vitePreprocess() })]
});
```

<!-- the following header generates an anchor that is used in logging, do not modify!-->
Expand Down
7 changes: 7 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,13 @@ export default [
'@typescript-eslint/no-unused-vars': 'off'
}
},
{
name: 'local/markdown-codefences/allow-require',
files: ['**/docs/faq.md/*.js'],
rules: {
'@typescript-eslint/no-require-imports': 'off'
}
},
{
name: 'local/spec-files',
files: ['**/__tests__/**/*.spec.ts'],
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"packageManager": "[email protected]",
"engines": {
"pnpm": "^10.2.0",
"node": "^20.18 || ^22 || >=24"
"node": "^20.19 || ^22.12 || >=24"
},
"pnpm": {
"overrides": {
Expand Down
10 changes: 4 additions & 6 deletions packages/vite-plugin-svelte-inspector/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@
"types": "types/index.d.ts",
"exports": {
".": {
"import": {
"types": "./types/index.d.ts",
"default": "./src/index.js"
}
"types": "./types/index.d.ts",
"default": "./src/index.js"
}
},
"scripts": {
Expand All @@ -23,7 +21,7 @@
"generate:types": "dts-buddy -m \"@sveltejs/vite-plugin-svelte-inspector:src/public.d.ts\""
},
"engines": {
"node": "^18.0.0 || ^20.0.0 || >=22"
"node": "^20.19 || ^22.12 || >=24"
},
"repository": {
"type": "git",
Expand All @@ -44,7 +42,7 @@
"debug": "^4.4.1"
},
"peerDependencies": {
"@sveltejs/vite-plugin-svelte": "^5.0.0",
"@sveltejs/vite-plugin-svelte": "workspace:^",
"svelte": "^5.0.0",
"vite": "^6.0.0"
},
Expand Down
10 changes: 4 additions & 6 deletions packages/vite-plugin-svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,8 @@
"types": "types/index.d.ts",
"exports": {
".": {
"import": {
"types": "./types/index.d.ts",
"default": "./src/index.js"
}
"types": "./types/index.d.ts",
"default": "./src/index.js"
}
},
"scripts": {
Expand All @@ -23,7 +21,7 @@
"generate:types": "dts-buddy -m \"@sveltejs/vite-plugin-svelte:src/public.d.ts\""
},
"engines": {
"node": "^18.0.0 || ^20.0.0 || >=22"
"node": "^20.19 || ^22.12 || >=24"
},
"repository": {
"type": "git",
Expand All @@ -41,7 +39,7 @@
},
"homepage": "https://github.com/sveltejs/vite-plugin-svelte#readme",
"dependencies": {
"@sveltejs/vite-plugin-svelte-inspector": "^4.0.1",
"@sveltejs/vite-plugin-svelte-inspector": "workspace:^",
"debug": "^4.4.1",
"deepmerge": "^4.3.1",
"kleur": "^4.1.5",
Expand Down