-
-
Notifications
You must be signed in to change notification settings - Fork 51
fix(no-unused-class-name): detect duplicated class names #1260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(no-unused-class-name): detect duplicated class names #1260
Conversation
🦋 Changeset detectedLatest commit: ffc2030 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your Local
Published Instant Preview Packages:
|
const classesUsedInTemplate: { | ||
className: string; | ||
loc: AST.SourceLocation; | ||
}[] = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this better in terms of performance?
const classesUsedInTemplate: { | |
className: string; | |
loc: AST.SourceLocation; | |
}[] = []; | |
const classesUsedInTemplate: Record<string, AST.SourceLocation[] = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think performance is no changes for now.
Because this code just execute by loop. (No access by key.)
If data structure is changed, I think code will be complex a little for now.
Co-authored-by: Yuichiro Yamashita <[email protected]>
close #1259