Check for app health checks and volume mounts before bluegreen build#4456
Open
kylemclaren wants to merge 4 commits intomasterfrom
Open
Check for app health checks and volume mounts before bluegreen build#4456kylemclaren wants to merge 4 commits intomasterfrom
bluegreen build#4456kylemclaren wants to merge 4 commits intomasterfrom
Conversation
kylemclaren
changed the title
bluegreen build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bluegreendeployment strategy will trigger a full build before it fails with a message that at least one health check needs to be configured and before an app with volumes cannot be used withbluegreen.This PR:
HasHealthChecks()helper onappconfig.Configfly deployearly for bluegreen strategy if no health checks are defined and an app has volume mounts