Skip to content

Conversation

@grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Jun 9, 2025

What kind of change does this PR introduce?

Add a new example on how to integrate Facebook SDK with the signInWithIdToken method.

@grdsdev grdsdev force-pushed the guilherme/example-facebook branch from 0881afd to 9bfcfb0 Compare June 9, 2025 09:45
@grdsdev grdsdev force-pushed the guilherme/example-facebook branch from 9bfcfb0 to 1c63ef6 Compare June 9, 2025 09:48
@grdsdev grdsdev requested a review from Copilot June 9, 2025 09:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a Facebook authentication example to the Supabase Swift SDK examples, including package dependency, example view, app delegate setup, and documentation.

  • Introduce facebook-ios-sdk in the Swift package resolution.
  • Create SignInWithFacebook view and wire it into the app lifecycle and AuthView.
  • Update Info.plist and README with Facebook App ID, client token, and URL scheme placeholders.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Supabase.xcworkspace/xcshareddata/swiftpm/Package.resolved Added facebook-ios-sdk dependency
Examples/README.md Documented Facebook Sign-In setup
Examples/Examples/Info.plist Added FacebookAppID, FacebookClientToken, URL schemes
Examples/Examples/ExamplesApp.swift Configured AppDelegate and SceneDelegate for Facebook Login
Examples/Examples/Auth/SignInWithFacebook.swift New SwiftUI view for Facebook sign-in example
Examples/Examples/Auth/AuthView.swift Integrated Facebook option into AuthView
Examples/Examples.xcodeproj/project.pbxproj Registered new source file and Swift package products
Comments suppressed due to low confidence (4)

Examples/Examples/Info.plist:20

  • [nitpick] Placeholder formatting includes spaces inside braces. Use a consistent placeholder name without spaces, e.g. {{DOT_REVERSED_IOS_CLIENT_ID}}, to avoid substitution errors.
<string>{{ DOT_REVERSED_IOS_CLIENT_ID }}</string>

Examples/Examples/Info.plist:26

  • Placeholder includes spaces and unusual naming. Consider using fb{{FACEBOOK_APP_ID}} to match typical placeholder conventions and ensure a valid URL scheme.
<string>fb{{ FACEBOOK APP ID }}</string>

Examples/README.md:13

  • Add a step to resolve Swift Package dependencies (e.g., via Xcode’s Swift Packages menu or swift package update) so the Facebook SDK is fetched before building.
3. Build and run the project (⌘R)

Examples/Examples/ExamplesApp.swift:19

  • Missing return statement in application(_:didFinishLaunchingWithOptions:). The method must return a Bool; either return the result of ApplicationDelegate.shared.application(...) or explicitly return true.
ApplicationDelegate.shared.application(

@coveralls
Copy link

coveralls commented Jun 9, 2025

Pull Request Test Coverage Report for Build 15531908710

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on guilherme/example-facebook at 75.652%

Totals Coverage Status
Change from base Build 15390678797: 75.7%
Covered Lines: 5223
Relevant Lines: 6904

💛 - Coveralls

@grdsdev grdsdev marked this pull request as ready for review August 12, 2025 10:41
@grdsdev grdsdev merged commit 717e8b5 into main Aug 14, 2025
24 checks passed
@grdsdev grdsdev deleted the guilherme/example-facebook branch August 14, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants