Skip to content

fix: ensure that messages partitions are created for self hosted environment. #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2025

Conversation

edgurgel
Copy link
Member

What kind of change does this PR introduce?

Ensure that messages partitions are created for self hosted environment. It also logs on success or on error so that's easier to know if seeding worked ✅

It fixes #1369

What is the current behavior?

It only ensures that migrations are executed.

The user would need to wait a significant amount of time for the Janitor to run.

What is the new behavior?

Seeds now run Janitor.MaintenanceTask

Additional context

Add any other context or screenshots.

edgurgel added 3 commits May 23, 2025 17:22
Always run with `docker run --rm` to ensure exited containers are not
left hanging

use docker ps without -a to only list running containers
@edgurgel edgurgel requested a review from filipecabaco May 23, 2025 05:23
Copy link

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview May 23, 2025 9:00am

Copy link
Member

@filipecabaco filipecabaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mix.exs needs updating

@coveralls
Copy link

Coverage Status

coverage: 82.652% (-0.5%) from 83.161%
when pulling 90a876e on fix/seeds-partitions
into e1562ca on main.

@edgurgel
Copy link
Member Author

@filipecabaco, done!

@edgurgel edgurgel requested a review from filipecabaco May 26, 2025 21:04
@edgurgel edgurgel merged commit 8fe0b2f into main May 26, 2025
6 of 7 checks passed
@edgurgel edgurgel deleted the fix/seeds-partitions branch May 26, 2025 21:47
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.35.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

filipecabaco pushed a commit that referenced this pull request May 27, 2025
…ronment. (#1383)

* chore: extract Janitor.MaintenanceTask
* fix: run Janitor.MaintenanceTask on seeds
* chore: fix containers set-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Janitor's 10-minute delay causes silent failures in local development
4 participants