-
-
Notifications
You must be signed in to change notification settings - Fork 358
fix: ensure that messages partitions are created for self hosted environment. #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+172
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always run with `docker run --rm` to ensure exited containers are not left hanging use docker ps without -a to only list running containers
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
filipecabaco
approved these changes
May 23, 2025
filipecabaco
requested changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mix.exs needs updating
@filipecabaco, done! |
filipecabaco
approved these changes
May 26, 2025
🎉 This PR is included in version 2.35.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
filipecabaco
pushed a commit
that referenced
this pull request
May 27, 2025
…ronment. (#1383) * chore: extract Janitor.MaintenanceTask * fix: run Janitor.MaintenanceTask on seeds * chore: fix containers set-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Ensure that messages partitions are created for self hosted environment. It also logs on success or on error so that's easier to know if seeding worked ✅
It fixes #1369
What is the current behavior?
It only ensures that migrations are executed.
The user would need to wait a significant amount of time for the Janitor to run.
What is the new behavior?
Seeds now run
Janitor.MaintenanceTask
Additional context
Add any other context or screenshots.