Skip to content

♿️(frontend) add sr-only format to export download button#2088

Merged
Ovgodd merged 1 commit intomainfrom
fix/export-format-vocalized
Mar 20, 2026
Merged

♿️(frontend) add sr-only format to export download button#2088
Ovgodd merged 1 commit intomainfrom
fix/export-format-vocalized

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 19, 2026

Purpose

Help screen reader users know which format will be exported before they click. Today they only hear "Download" and can't tell if it's PDF, DOCX, etc.

Proposal

  • Add the selected format to the download button’s aria-label (e.g. "Download PDF") for screen readers
  • Remove the redundant aria-label that repeated the visible text
  • Simplify the code by using one shared list of format options

@Ovgodd Ovgodd requested a review from AntoLC March 19, 2026 14:24
@Ovgodd Ovgodd self-assigned this Mar 19, 2026
@Ovgodd Ovgodd changed the title ♿️(frontend) add format to export download button aria-label for scre… ♿️(frontend) add sr-only format to export download button Mar 19, 2026
@Ovgodd Ovgodd force-pushed the fix/export-format-vocalized branch from da963c3 to f767f2a Compare March 19, 2026 14:26
@Ovgodd Ovgodd marked this pull request as ready for review March 19, 2026 14:26
@Ovgodd Ovgodd force-pushed the fix/export-format-vocalized branch from f767f2a to 13fe3f8 Compare March 19, 2026 14:27
@Ovgodd Ovgodd linked an issue Mar 19, 2026 that may be closed by this pull request
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 19, 2026
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Size Change: +7 B (0%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/56355b45/_buildManifest.js 0 B -905 B (removed) 🏆
apps/impress/out/_next/static/fdc1d82d/_buildManifest.js 905 B +905 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/export-format-vocalized branch from 13fe3f8 to 905492b Compare March 20, 2026 08:31
@Ovgodd Ovgodd force-pushed the fix/export-format-vocalized branch 2 times, most recently from 86a4f28 to e32b77c Compare March 20, 2026 09:30
Add format to export button aria-label for a11y. DRY format options.
@Ovgodd Ovgodd force-pushed the fix/export-format-vocalized branch from e32b77c to 2a708d6 Compare March 20, 2026 10:27
@Ovgodd Ovgodd merged commit 2a708d6 into main Mar 20, 2026
33 of 35 checks passed
@Ovgodd Ovgodd deleted the fix/export-format-vocalized branch March 20, 2026 11:56
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Download button label

2 participants