♿️(frontend) improve version history modal accessibility#2033
Merged
Conversation
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
2 times, most recently
from
73a6ce7 to
e071832
Compare
|
Size Change: +173 B (0%) Total Size: 4.23 MB
|
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
from
e071832 to
70d8c4b
Compare
Ovgodd
changed the title
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
from
a4e73fe to
0e70ef8
Compare
AntoLC
reviewed
Mar 18, 2026
src/frontend/apps/impress/src/features/docs/doc-versioning/components/VersionList.tsx
Outdated
Show resolved
Hide resolved
AntoLC
approved these changes
Mar 19, 2026
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
8 times, most recently
from
f612758 to
3ab51d2
Compare
Dynamic aria-label per version, aria-pressed + live region
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
from
3ab51d2 to
0beaf69
Compare
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
from
0beaf69 to
07a7260
Compare
Replace hardcoded aria-label with aria-lab trad.
Ovgodd
force-pushed
the
fix/history-list-explicit-vocalize
branch
from
07a7260 to
cdf3161
Compare
lunika
added a commit
that referenced
this pull request
Mar 21, 2026
Changed - 💫(frontend) fix the help button to the bottom in tree #2073 - ♿️(frontend) improve version history list accessibility #2033 - ♿️(frontend) fix more options menu feedback for screen readers #2071 - ♿(frontend) focus skip link on headings and skip grid dropzone #1983 - ♿️(frontend) fix search modal accessibility issues #2054 - ♿️(frontend) add sr-only format to export download button #2088 - ♿️(frontend) announce formatting shortcuts for screen readers #2070 - ✨(frontend) add markdown copy icon for Copy as Markdown option #2096 - ♻️(backend) skip saving in database a document when payload is empty #2062 Fixed - ♿️(frontend) fix aria-labels for table of contents #2065 - 🐛(backend) allow using search endpoint without refresh token enabled #2097
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix accessibility issues in the version history list: each version button was announced as "version item" by screen readers, the focus was not visible when tabbing, and the HTML structure was invalid (
<li>inside<button>). Also ensure the modal's accessible name is translated (e.g. "Historique des versions" in French instead of "version history modal" in English).Proposal
aria-label="version item"with a dynamic translated label including the version datearia-pressedand a live region to announce the selected versionrole="listbox"torole="list"so Tab/Enter works on all items<li>for valid<ul> > <li> > <button>structurearia-label="version history modal"witharia-labelledbypointing to the translated h1aria-label="version list"with i18n