Skip to content

♿️(frontend) improve version history modal accessibility#2033

Merged
Ovgodd merged 2 commits intomainfrom
fix/history-list-explicit-vocalize
Mar 19, 2026
Merged

♿️(frontend) improve version history modal accessibility#2033
Ovgodd merged 2 commits intomainfrom
fix/history-list-explicit-vocalize

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 17, 2026

Purpose

Fix accessibility issues in the version history list: each version button was announced as "version item" by screen readers, the focus was not visible when tabbing, and the HTML structure was invalid (<li> inside <button>). Also ensure the modal's accessible name is translated (e.g. "Historique des versions" in French instead of "version history modal" in English).

Proposal

  • Replace static aria-label="version item" with a dynamic translated label including the version date
  • Add visible focus background on version items for keyboard navigation
  • Add aria-pressed and a live region to announce the selected version
  • Change role="listbox" to role="list" so Tab/Enter works on all items
  • Wrap each button in a <li> for valid <ul> > <li> > <button> structure
  • Replace aria-label="version history modal" with aria-labelledby pointing to the translated h1
  • Translate aria-label="version list" with i18n

@Ovgodd Ovgodd requested a review from AntoLC March 17, 2026 11:00
@Ovgodd Ovgodd self-assigned this Mar 17, 2026
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch 2 times, most recently from 73a6ce7 to e071832 Compare March 17, 2026 11:06
@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Size Change: +173 B (0%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/8b4a8f97/_buildManifest.js 905 B +905 B (new file) 🆕
apps/impress/out/_next/static/e765e2e4/_buildManifest.js 0 B -905 B (removed) 🏆

compressed-size-action

@Ovgodd Ovgodd linked an issue Mar 17, 2026 that may be closed by this pull request
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 17, 2026
@Ovgodd Ovgodd marked this pull request as ready for review March 17, 2026 11:08
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch from e071832 to 70d8c4b Compare March 17, 2026 11:08
@Ovgodd Ovgodd marked this pull request as draft March 18, 2026 08:37
@Ovgodd Ovgodd changed the title ♿️(frontend) improve version history list accessibility ♿️(frontend) improve version history modal accessibility Mar 18, 2026
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch from a4e73fe to 0e70ef8 Compare March 18, 2026 08:55
@Ovgodd Ovgodd linked an issue Mar 18, 2026 that may be closed by this pull request
@Ovgodd Ovgodd marked this pull request as ready for review March 18, 2026 09:00
@Ovgodd Ovgodd requested a review from AntoLC March 18, 2026 13:03
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch 8 times, most recently from f612758 to 3ab51d2 Compare March 19, 2026 11:53
Dynamic aria-label per version, aria-pressed + live region
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch from 3ab51d2 to 0beaf69 Compare March 19, 2026 13:05
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch from 0beaf69 to 07a7260 Compare March 19, 2026 14:31
Replace hardcoded aria-label with aria-lab trad.
@Ovgodd Ovgodd force-pushed the fix/history-list-explicit-vocalize branch from 07a7260 to cdf3161 Compare March 19, 2026 14:52
@Ovgodd Ovgodd merged commit cdf3161 into main Mar 19, 2026
26 of 27 checks passed
@Ovgodd Ovgodd deleted the fix/history-list-explicit-vocalize branch March 19, 2026 17:32
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

More options menu: Accessible name of the version history modal More options modal: Missing explicit title for each version

2 participants