perf: remove unnecessary retry loop in string generation#95
Closed
sudorandom wants to merge 1 commit intomainfrom
Closed
perf: remove unnecessary retry loop in string generation#95sudorandom wants to merge 1 commit intomainfrom
sudorandom wants to merge 1 commit intomainfrom
Conversation
Removed the retry loop in `gen_strings.go` when generating strings with regex patterns. This eliminates redundant calls to the expensive regex generator (up to 5 times), as length constraints are already handled by subsequent padding and truncation logic. Also corrected the Go version in `go.mod` from `1.25.7` to `1.24.3` to align with available toolchains. Co-authored-by: sudorandom <310004+sudorandom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the retry loop in
gen_strings.gowhen generating strings with regex patterns. This eliminates redundant calls to the expensive regex generator (up to 5 times), as length constraints are already handled by subsequent padding and truncation logic.Also corrected the Go version in
go.modfrom1.25.7to1.24.3to align with available toolchains.