Skip to content

⚡ Optimize Enum slice allocation#91

Merged
sudorandom merged 1 commit intomainfrom
perf/optimize-enum-slice-16328042578279410418
Feb 26, 2026
Merged

⚡ Optimize Enum slice allocation#91
sudorandom merged 1 commit intomainfrom
perf/optimize-enum-slice-16328042578279410418

Conversation

@sudorandom
Copy link
Copy Markdown
Owner

💡 What: Pre-allocate the allowedValues slice in gen_enum.go using make with the known capacity of allEnumValues.Len().
🎯 Why: To avoid inefficient slice appending and potential re-allocations when iterating over enum values. This is an O(N) allocation improvement for large enums.
📊 Measured Improvement:
Created a benchmark BenchmarkEnumFunction in gen_enum_benchmark_test.go.
For small enums (2-4 values), the improvement is negligible/not measurable due to stack allocation optimizations and dominance of other operations (~87-190 ns/op).
However, for larger enums (which may exist in user schemas), this change avoids O(log N) reallocations and ensures O(1) allocation overhead.


PR created automatically by Jules for task 16328042578279410418 started by @sudorandom

Pre-allocate `allowedValues` slice to avoid re-allocations during loop.
Added `gen_enum_benchmark_test.go` to verify performance.

Co-authored-by: sudorandom <310004+sudorandom@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sudorandom sudorandom merged commit a6889eb into main Feb 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant