terminal: preserve quickstart errors and detect interrupts robustly#1499
Open
lofimichael wants to merge 4 commits intostripe:masterfrom
Open
terminal: preserve quickstart errors and detect interrupts robustly#1499lofimichael wants to merge 4 commits intostripe:masterfrom
lofimichael wants to merge 4 commits intostripe:masterfrom
Conversation
|
|
Collaborator
|
hi! i'm kind of curious, are you using this feature? we've been trying to find users of it to learn more about they're usage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stripe terminal quickstartwas comparing prompt interrupts by string and rewrapping errors into identical strings before returning them.This updates the quickstart path to use
errors.Is(err, promptui.ErrInterrupt)and return the original errors directly. That keeps interrupt handling robust if those errors are wrapped, without changing the existing behavior for non-interrupt failures.Testing