Skip to content

terminal: preserve quickstart errors and detect interrupts robustly#1499

Open
lofimichael wants to merge 4 commits intostripe:masterfrom
lofimichael:lofimichael/stripe-cli-rules
Open

terminal: preserve quickstart errors and detect interrupts robustly#1499
lofimichael wants to merge 4 commits intostripe:masterfrom
lofimichael:lofimichael/stripe-cli-rules

Conversation

@lofimichael
Copy link
Copy Markdown

Summary

stripe terminal quickstart was comparing prompt interrupts by string and rewrapping errors into identical strings before returning them.

This updates the quickstart path to use errors.Is(err, promptui.ErrInterrupt) and return the original errors directly. That keeps interrupt handling robust if those errors are wrapped, without changing the existing behavior for non-interrupt failures.

Testing

  • make lint
  • make ci

@lofimichael lofimichael requested a review from a team as a code owner March 20, 2026 18:22
@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 20, 2026

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Mar 20, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tomer-stripe
Copy link
Copy Markdown
Collaborator

hi! i'm kind of curious, are you using this feature? we've been trying to find users of it to learn more about they're usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants