-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ST] Add systemtest with user specific configuraton for ssl.* fields for custom type of listener #11500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/packit test --labels regression --env TESTS=ListenersST,CustomCaST |
2 similar comments
/packit test --labels regression --env TESTS=ListenersST,CustomCaST |
/packit test --labels regression --env TESTS=ListenersST,CustomCaST |
/azp run regression |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good, thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just few nits.
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Outdated
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Show resolved
Hide resolved
systemtest/src/test/java/io/strimzi/systemtest/kafka/listeners/ListenersST.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just few nits, which should be applied. Good job 👍 .
…ustom type of listener Signed-off-by: Jakub Stejskal <[email protected]>
Signed-off-by: Jakub Stejskal <[email protected]>
Signed-off-by: Jakub Stejskal <[email protected]>
Signed-off-by: Jakub Stejskal <[email protected]>
Signed-off-by: Jakub Stejskal <[email protected]>
212b9ab
to
468d809
Compare
Type of change
Description
This PR adds system test for #11052
It also removes some classes for certs generation that can be used from test-frame library now.
Checklist