Fixed null checking in IndexBufferBinding equals operator#3078
Open
johang88 wants to merge 2 commits intostride3d:masterfrom
Open
Fixed null checking in IndexBufferBinding equals operator#3078johang88 wants to merge 2 commits intostride3d:masterfrom
johang88 wants to merge 2 commits intostride3d:masterfrom
Conversation
Ethereal77
reviewed
Feb 28, 2026
johang88
force-pushed
the
index-buffer-binding-equality
branch
from
9b343ff to
8e60165
Compare
ds5678
suggested changes
Mar 4, 2026
Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
The
==would throw on null arrguments causing a crash in MeshRenderFeature if no index buffer was set in the draw data.Types of changes
Checklist