[Launcher] #2744 - Improved Avalonia launcher UI.#2931
[Launcher] #2744 - Improved Avalonia launcher UI.#2931ghost wants to merge 5 commits intoxplat-editorfrom unknown repository
Conversation
-- Improved MessageBox UX. -- Improved spacing in engine version minor popup. -- Integrated window title-bar into window.
Also removed LastChildFill param to conform with other DockPanels
@dotnet-policy-service agree |
|
It seems reasonable to me. Though the title bar implementation is missing a few properties on Linux:
Other than that, I have no comments 😃 Treat above nitpicks as optional |
|
What's the goal of having this custom title bar ? Especially edit: ok I see what it does on Windows: it displays the vector icon instead of the image one. Nice attempt, but unfortunately it is not portable and doesn't work on Linux. So I'd prefer to revert that change until Avalonia offers a portable API to do so. It might even behave differently on macOs. |
|
The title-bar change aimed to match the original launcher's appearance. Using MainView for title-bar behaviour seemed practical given the simple window structure, but I failed to consider cross-platform responses of this behaviour. I'll revert this change! We could implement window chrome in-app (like Steam, Epic, GOG) rather than relying on platform interpretations. The drawback is that it won't adapt to desktop environment conventions like GNOME users would see minimize/maximize buttons despite GNOME typically only showing close. Nor would it be able to use native title-bar features like gesture support, although this might not be that big of a deal if we restrict the launcher's ability to resize. |
|
@VeiledSprite thanks. Could you comment on the linked issue so that I can assign it to you? |
|
Sorry I meant to add a comment on the issue itself. |
|
🤦♂️ My mistake! |
ghost
mentioned this pull request
sources/presentation/Stride.Core.Presentation.Avalonia/Windows/MessageBox.axaml
Show resolved
Hide resolved
-- Resorted to using even numbers for margins and paddings. -- Reverted changes to MessageBox. -- Used double space instead of tab. -- Added axaml type to be included to editor rules.
Kryptos-FR
left a comment
Kryptos-FR
left a comment
There was a problem hiding this comment.
Some changes are ok, especially capturing the mouse wheel. However I'm not a fan of the button's margin inside the drop down to select the versions.
| Command="{Binding SetAsActiveCommand}" | ||
| HorizontalAlignment="Stretch" HorizontalContentAlignment="Left"> | ||
| HorizontalAlignment="Stretch" HorizontalContentAlignment="Left" | ||
| Padding="4" Margin="4"> |
There was a problem hiding this comment.
I think this margin is not necessary. It looks a bit ugly. Padding is ok.
ghost
closed this by deleting the head repository
2 participants
PR Details
Conservatively improved the layout of the Avalonia launcher, bringing it more in line with the current version. Added a tiny amount of logic to control the integrated title-bar as well as focusing the ScrollViewer in the contextual popup so the scroll wheel doesn't try to interact with the ScrollViewer behind it.
Apologies in advance if I've messed anything up in terms of procedures, this is my first open source contribution!
Some screenshots:
Related Issue
#2744
Types of changes
Checklist