fix: DoubleExtension & IntExtension

[Jklawreszuk]

PR Details

PR fixes following bug:

1. Run new Avalonia Editor on Windows (dotnet run)
2. Load any game solution file.
3. Select any asset or go to settings.
4. Crash :

Exception: FormatException: The input string '0.5' was not in a correct format.

I simply used passed additional CultureInfo argument to take into account the different formats (dots or commas) that occur between languages.

My Current LocaleInfo : pl-PL

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My change requires a change to the documentation.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have built and run the editor to try this change out.

[Jklawreszuk]

We dont need to use object as type since its always a string

[Jklawreszuk]

Huh.. I realized that Convert.ToDouble(string, IFormarProvider) uses double.Parse under the hood but is checking for nulls. Lets use that 😄

[Kryptos-FR]

I don't have that crash. Double extension is a markup extension which is only used on the xaml side.

Can you give more details on your config. For instance, what's the current language and locale of your machine?

[Kryptos-FR]

I haven't tested with other culture so I kind of understand why the fix could be needed.

With that said, DoubleExtension is not the only one doing a conversion. Others should be fixed as well.

[Jklawreszuk]

Double extension is a markup extension which is only used on the xaml side.

Yeah, because it is parsed as text, I concluded that it would be better to declare it as string, for now 😅 But yeah I guess consequently it would be useful to change the rest of the extensions in this way, so I'm going to undo that

I don't have that crash.

That's because my case is niche, I think? 😅 My current Locale is pl-PL, but OS language is en-US. I'm just used to various settings written in English etc. This is probably the cause of the issue

[Kryptos-FR]

So the reasons it didn't crash in WPF is that bindings are more tolerant in WPF (exception is caught somewhere and doesn't crash the whole app), and secondly it doesn't look like we had cases where the value had a decimal part (and hence no formatting issue).

[Kryptos-FR]

With that said, DoubleExtension is not the only one doing a conversion. Others should be fixed as well.

The only other one actually is IntExtension which shouldn't have the same issue since there are no decimal parts. To be safer, let's also force the use of the InvariantCulture for IntExtension.

[Jklawreszuk]

@Kryptos-FR Sounds good to me, let's handle it even though it may be a small chance for an exception.