feat: styles for theme variants#2819
Merged
Kryptos-FR merged 7 commits intostride3d:xplat-editorfrom Jun 19, 2025
Merged
Conversation
This was
linked to
issues
Jun 17, 2025
493c6fa to
0f78202
Compare
0f78202 to
316ab41
Compare
316ab41 to
57d6720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
The Fluent theme that we are using has two variants: dark and light. Instead of hard-coding values (such as colors), we will use the corresponding resource keys to ensure consistency.
In addition, this theme supports having an "accent" color. Modern desktop (Windows, Linux) let the user define which accent they want for their apps. So we should take that into account.
Related Issues
Types of changes
Checklist