[HardwareSerial] Fix ambiguous call of overloaded function #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
error: call of overloaded 'HardwareSerial(int, int)' is ambiguous`
1 | HardwareSerial Serialx(0, 1);
| ^
In file included from cores/arduino/WSerial.h:5,
from cores/arduino/wiring.h:47,
from cores/arduino/Arduino.h:32,
from sketch_jan27b.ino.cpp:1:
cores/arduino/HardwareSerial.h:106:5: note: candidate: 'HardwareSerial::HardwareSerial(void*, bool)'
106 | HardwareSerial(void *peripheral, bool halfDuplex = false);
| ^~~~~~~~~~~~~~
cores/arduino/HardwareSerial.h:104:5: note: candidate: 'HardwareSerial::HardwareSerial(uint32_t, uint32_t)'
104 | HardwareSerial(uint32_t _rx, uint32_t _tx);
| ^~~~~~~~~~~~~~
```
When the Rx Pin is 0 then the compiler doesn't know which constructor
to use as 0 can be interpreted like NULL. So both of them are valid:
HardwareSerial(uint32_t _rx, uint32_t _tx);
HardwareSerial(void *peripheral, bool halfDuplex = false);
Defining an explicit type avoid this issue.
Signed-off-by: Frederic Pillon <[email protected]>
ABOSTM
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Rx Pin is 0 then the compiler doesn't know which constructor
to use as 0 can be interpreted like NULL. So both of them are valid:
Defining an explicit type avoid this issue.
Issue reported here:
https://www.stm32duino.com/viewtopic.php?f=13&t=137