Skip to content

Prepare for 1.1.0 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Prepare for 1.1.0 #105

merged 13 commits into from
Oct 20, 2022

Conversation

jadamcrain
Copy link
Member

No description provided.

@jadamcrain jadamcrain merged commit 6396608 into main Oct 20, 2022
@jadamcrain jadamcrain deleted the release/prep-1.1.0 branch October 20, 2022 16:31
@yacoubhanna
Copy link

yacoubhanna commented Nov 9, 2023

Hello @jadamcrain,

I was trying to build the C files in ffi/bindings/c by doing "cmake ." and I got this error

No local rodbus, fetching remote library version 1.0.0
[ 11%] Performing download step (download, verify and extract) for 'rodbus-populate'
-- File already exists but no hash specified (use URL_HASH):
  file='/home/yacoub/Desktop/Modbus/rodbus/ffi/bindings/c/_deps/rodbus-subbuild/rodbus-populate-prefix/src/rodbus-1.0.0.zip'
Old file will be removed and new file downloaded from URL.
-- Downloading...
   dst='/home/yacoub/Desktop/Modbus/rodbus/ffi/bindings/c/_deps/rodbus-subbuild/rodbus-populate-prefix/src/rodbus-1.0.0.zip'
   timeout='none'
-- Using src='https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip'
-- Retrying...
-- Using src='https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip'
-- Retry after 5 seconds (attempt #2) ...
-- Using src='https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip'
-- Retry after 5 seconds (attempt #3) ...
-- Using src='https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip'
-- Retry after 15 seconds (attempt #4) ...
-- Using src='https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip'
-- Retry after 60 seconds (attempt #5) ...
-- Using src='https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip'
CMake Error at rodbus-subbuild/rodbus-populate-prefix/src/rodbus-populate-stamp/download-rodbus-populate.cmake:159 (message):
  Each download failed!

    error: downloading 'https://github.com/stepfunc/rodbus/releases/download/1.0.0/rodbus-1.0.0.zip' failed
         status_code: 22
         status_string: "HTTP response code said error"
         log:
         --- LOG BEGIN ---
           Trying 140.82.114.3:443...

**Please update the CMakeLists.txt file **
From set(RODBUS_BACKUP_VERSION "1.0.0") -------> set(RODBUS_BACKUP_VERSION "1.3.1")

Thank you :)

@jadamcrain
Copy link
Member Author

@yacoubhanna Thanks for pointing this out. I've created an issue to get this updated for the next release:

#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants