test : Runtime SSR Testing Improvements#756
Open
OS-paulvisciano wants to merge 5 commits into
Open
Conversation
OS-paulvisciano
changed the title
OS-paulvisciano
force-pushed
the
testing-improvements
branch
from
a7380dc to
5140a96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
NextJs Runtime SSR throws hydration errors, currently those errors are ignored. This PR adds a test to properly detect those errors per component, adds a bunch of additional components to test for SSR & a coverage report that helps show which components properly support SSR. The report also tracks environment information per test run, which helped figure out what version of core/output-targets caused SSR regressions.
Issue URL:
What is the new behavior?
The goal of this PR is to start moving us in the direction of clearly communicating what components properly support SSR and which ones do not. @OS-jacobbell & I have been working on making improvements to the NextJs Runtime SSR support and identified several regressions that led to a lot of mismatch errors during hydration. While working on fixes, we found the HTML report useful for tracking where the regressions began & tracking progress of the fixes. There will be a follow up PR with the fixes
Note: The
ssr-compatibility.test.tsis currently excluded from the test run (viawdio.conf.ts) to prevent CI failures until the hydration mismatch fixes are merged.Does this introduce a breaking change?
Other information