Skip to content

Conversation

@jlajardie
Copy link

@jlajardie jlajardie commented May 27, 2025

This PR is related to issues #65 and #87

It allows to login back to the impersonator's panel (or any other) without any error. I also made a PR on laravel-impersonate to avoid being logged out from the impersonator's panel if the guard is different than the impersonated's one. (Can't do it from here because it doesn't log out from the impersonated user when you press the "Leave" button as it is a link to laravel-impersonate)

@V13Axel
Copy link
Collaborator

V13Axel commented Dec 29, 2025

@jlajardie Not sure if you've upgraded your apps to Filament v4 yet, but if you are and you'd like to rebase this from current master, I can test from there and see about getting it merged.

jszobody added a commit that referenced this pull request Jan 16, 2026
Only render the impersonation banner when the current panel's auth guard
matches the impersonator's original guard. This prevents a TypeError crash
when navigating between panels with different guards while impersonating.

Fixes #65, #87
Related to #114
jszobody added a commit that referenced this pull request Jan 16, 2026
Only render the impersonation banner when the current panel's auth guard
matches the impersonator's original guard. This prevents a TypeError crash
when navigating between panels with different guards while impersonating.

Fixes #65, #87
Related to #114
@jszobody
Copy link
Member

Closing this in favor of #137

@jszobody jszobody closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants