Skip to content

chore: fix C lint errors (issue #7185) #7217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

GeoDaoyu
Copy link
Contributor

@GeoDaoyu GeoDaoyu commented Jun 5, 2025

Resolves #7185.

Description

What is the purpose of this pull request?

This pull request:

  • fix C lint errors

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jun 5, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/snanmskmax $\color{green}470/470$
$\color{green}+100.00\%$
$\color{green}57/57$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}470/470$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 5, 2025
@kgryte
Copy link
Member

kgryte commented Jun 5, 2025

@GeoDaoyu Would you mind fully resolving #7185? Currently, you only address the lint errors in snanmskmax, but not math/strided/dfloor.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jun 5, 2025
@GeoDaoyu
Copy link
Contributor Author

GeoDaoyu commented Jun 5, 2025

@kgryte hello, the lint errors in lib/node_modules/@stdlib/math/strided/special/dfloor/benchmark/c/benchmark.length.c has been fixed in #7071. I inspect it in the develop branch.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jun 5, 2025
@kgryte
Copy link
Member

kgryte commented Jun 5, 2025

@GeoDaoyu Thank you for the follow up!

@kgryte kgryte merged commit d4effdb into stdlib-js:develop Jun 5, 2025
67 checks passed
@GeoDaoyu GeoDaoyu deleted the Fix/CLint7185 branch June 5, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
3 participants