-
-
Notifications
You must be signed in to change notification settings - Fork 836
feat: add math/base/special/cphasef
#7158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7293c7b
feat: add `math/base/special/cphasef`
anandkaranubc b15bec3
Merge branch 'develop' into feat/cphasef
anandkaranubc 792eba0
test: update tolerances
anandkaranubc 7183283
chore: fix header include
anandkaranubc 8155509
Merge branch 'develop' into feat/cphasef
anandkaranubc 28b05e8
bench: use `random_uniform`
anandkaranubc ff9bbb5
docs: refactor examples to use `log-each-map`
anandkaranubc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
202 changes: 202 additions & 0 deletions
202
lib/node_modules/@stdlib/math/base/special/cphasef/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,202 @@ | ||
<!-- | ||
|
||
@license Apache-2.0 | ||
|
||
Copyright (c) 2025 The Stdlib Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
|
||
--> | ||
|
||
# cphasef | ||
|
||
> Compute the [argument][complex-number-argument] of a single-precision complex floating-point number in radians. | ||
|
||
<section class="intro"> | ||
|
||
The [argument][complex-number-argument] of a complex number, also known as the **phase**, is the angle of the radius extending from the origin to the complex number plotted in the complex plane and the positive real axis. | ||
|
||
</section> | ||
|
||
<!-- /.intro --> | ||
|
||
<section class="usage"> | ||
|
||
## Usage | ||
|
||
```javascript | ||
var cphasef = require( '@stdlib/math/base/special/cphasef' ); | ||
``` | ||
|
||
#### cphasef( z ) | ||
|
||
Computes the [argument][complex-number-argument] of a single-precision complex floating-point number. | ||
|
||
```javascript | ||
var Complex64 = require( '@stdlib/complex/float32/ctor' ); | ||
|
||
var phi = cphasef( new Complex64( 5.0, 3.0 ) ); | ||
// returns ~0.5404 | ||
``` | ||
|
||
</section> | ||
|
||
<!-- /.usage --> | ||
|
||
<section class="examples"> | ||
|
||
## Examples | ||
|
||
<!-- eslint no-undef: "error" --> | ||
|
||
```javascript | ||
var Complex64 = require( '@stdlib/complex/float32/ctor' ); | ||
var uniform = require( '@stdlib/random/base/uniform' ); | ||
var cphasef = require( '@stdlib/math/base/special/cphasef' ); | ||
|
||
var z; | ||
var i; | ||
|
||
for ( i = 0; i < 100; i++ ) { | ||
z = new Complex64( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ); | ||
console.log( 'arg(%s) = %d', z.toString(), cphasef( z ) ); | ||
} | ||
``` | ||
|
||
</section> | ||
|
||
<!-- /.examples --> | ||
|
||
<!-- C interface documentation. --> | ||
|
||
* * * | ||
|
||
<section class="c"> | ||
|
||
## C APIs | ||
|
||
<!-- Section to include introductory text. Make sure to keep an empty line after the intro `section` element and another before the `/section` close. --> | ||
|
||
<section class="intro"> | ||
|
||
</section> | ||
|
||
<!-- /.intro --> | ||
|
||
<!-- C usage documentation. --> | ||
|
||
<section class="usage"> | ||
|
||
### Usage | ||
|
||
```c | ||
#include "stdlib/math/base/special/cphasef.h" | ||
``` | ||
|
||
#### stdlib_base_cphasef( z ) | ||
|
||
Computes the [argument][complex-number-argument] of a single-precision complex floating-point number. | ||
|
||
```c | ||
#include "stdlib/complex/float32/ctor.h" | ||
#include "stdlib/complex/float32/real.h" | ||
#include "stdlib/complex/float32/imag.h" | ||
|
||
stdlib_complex64_t z = stdlib_complex64( 5.0f, 3.0f ); | ||
float out = stdlib_base_cphasef( z ); | ||
// returns ~0.5404f | ||
``` | ||
|
||
The function accepts the following arguments: | ||
|
||
- **z**: `[in] stdlib_complex64_t` input value. | ||
|
||
```c | ||
float stdlib_base_cphasef( const stdlib_complex64_t z ); | ||
``` | ||
|
||
</section> | ||
|
||
<!-- /.usage --> | ||
|
||
<!-- C API usage notes. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||
|
||
<section class="notes"> | ||
|
||
</section> | ||
|
||
<!-- /.notes --> | ||
|
||
<!-- C API usage examples. --> | ||
|
||
<section class="examples"> | ||
|
||
### Examples | ||
|
||
```c | ||
#include "stdlib/math/base/special/cphasef.h" | ||
#include "stdlib/complex/float32/ctor.h" | ||
#include "stdlib/complex/float32/reim.h" | ||
#include <stdio.h> | ||
|
||
int main( void ) { | ||
const stdlib_complex64_t x[] = { | ||
stdlib_complex64( 3.14f, 1.0f ), | ||
stdlib_complex64( -3.14f, -1.0f ), | ||
stdlib_complex64( 0.0f, 0.0f ), | ||
stdlib_complex64( 0.0f/0.0f, 0.0f/0.0f ) | ||
}; | ||
|
||
stdlib_complex64_t v; | ||
float re; | ||
float im; | ||
float y; | ||
int i; | ||
for ( i = 0; i < 4; i++ ) { | ||
v = x[ i ]; | ||
y = stdlib_base_cphasef( v ); | ||
stdlib_complex64_reim( v, &re, &im ); | ||
printf( "fcphasef(%f + %fi) = %f\n", re, im, y ); | ||
} | ||
} | ||
``` | ||
|
||
</section> | ||
|
||
<!-- /.examples --> | ||
|
||
</section> | ||
|
||
<!-- /.c --> | ||
|
||
<!-- Section for related `stdlib` packages. Do not manually edit this section, as it is automatically populated. --> | ||
|
||
<section class="related"> | ||
|
||
</section> | ||
|
||
<!-- /.related --> | ||
|
||
<!-- Section for all links. Make sure to keep an empty line after the `section` element and another before the `/section` close. --> | ||
|
||
<section class="links"> | ||
|
||
[complex-number-argument]: https://en.wikipedia.org/wiki/Argument_%28complex_analysis%29 | ||
|
||
<!-- <related-links> --> | ||
|
||
<!-- </related-links> --> | ||
|
||
</section> | ||
|
||
<!-- /.links --> |
56 changes: 56 additions & 0 deletions
56
lib/node_modules/@stdlib/math/base/special/cphasef/benchmark/benchmark.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2025 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var uniform = require( '@stdlib/random/base/uniform' ); | ||
var Complex64 = require( '@stdlib/complex/float64/ctor' ); | ||
var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | ||
var pkg = require( './../package.json' ).name; | ||
var cphasef = require( './../lib' ); | ||
|
||
|
||
// MAIN // | ||
|
||
bench( pkg, function benchmark( b ) { | ||
var values; | ||
var y; | ||
var i; | ||
|
||
values = [ | ||
new Complex64( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ), | ||
new Complex64( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ) | ||
]; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
y = cphasef( values[ i%values.length ] ); | ||
if ( isnanf( y ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( isnanf( y ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
}); |
65 changes: 65 additions & 0 deletions
65
lib/node_modules/@stdlib/math/base/special/cphasef/benchmark/benchmark.native.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2025 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var resolve = require( 'path' ).resolve; | ||
var bench = require( '@stdlib/bench' ); | ||
var uniform = require( '@stdlib/random/base/uniform' ); | ||
var isnanf = require( '@stdlib/math/base/assert/is-nanf' ); | ||
var Complex64 = require( '@stdlib/complex/float32/ctor' ); | ||
var tryRequire = require( '@stdlib/utils/try-require' ); | ||
var pkg = require( './../package.json' ).name; | ||
|
||
|
||
// VARIABLES // | ||
|
||
var cphasef = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||
var opts = { | ||
'skip': ( cphasef instanceof Error ) | ||
}; | ||
|
||
|
||
// MAIN // | ||
|
||
bench( pkg+'::native', opts, function benchmark( b ) { | ||
var values; | ||
var y; | ||
var i; | ||
|
||
values = [ | ||
new Complex64( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ), | ||
new Complex64( uniform( -500.0, 500.0 ), uniform( -500.0, 500.0 ) ) | ||
]; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
y = cphasef( values[ i%values.length ] ); | ||
if ( isnanf( y ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( isnanf( y ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this supposed to be
(also notice that JS example above has
arg
)?Same question applies to
example.c
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was being used in
cphase
, but I can revisit that and update it too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdlib/lib/node_modules/@stdlib/math/base/special/cphase/examples/index.js
Line 30 in 0160d55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdlib/lib/node_modules/@stdlib/math/base/special/cphase/examples/c/example.c
Line 41 in 0160d55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that has to be a typo. The
README.md
ofcphase
usescphase
:https://github.com/stdlib-js/stdlib/tree/0160d55258f7e58e3e9bb2ad1a2c345575343515/lib/node_modules/%40stdlib/math/base/special/cphase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also move forward and do the same changes in
cphase
as done here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be great!