Skip to content

chore: fix JavaScript lint errors (issue #7024) #7037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

chore: fix JavaScript lint errors (issue #7024) #7037

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3671e5
chore: fix JavaScript lint errors (issue #7024)
udaykakade25 May 19, 2025
6c2a736
new Array() style changed
udaykakade25 May 19, 2025
5625c8e
Discard changes to lib/node_modules/@stdlib/constants/float64/max-saf…
kgryte May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@
*/

'use strict';

// eslint-disable-next-line no-warning-comments

Check failure on line 20 in lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Missing empty line before comment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// eslint-disable-next-line no-warning-comments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to flag warning comments such as this. Disabling prevents us from doing so. That also applies below. Please just focus on updating the loop.

// TODO: improve JSDoc examples

Check failure on line 21 in lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Missing empty line before comment

// MODULES //

var EventEmitter = require( 'events' ).EventEmitter;
var logger = require( 'debug' );
var linear = require( 'd3-scale' ).scaleLinear; // TODO: remove
var linear = require( 'd3-scale' ).scaleLinear;
// eslint-disable-next-line no-warning-comments

Check failure on line 28 in lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Missing empty line before comment
// TODO: remove

Check failure on line 29 in lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Missing empty line before comment
var defineProperty = require( '@stdlib/utils/define-property' );
var setReadOnly = require( '@stdlib/utils/define-read-only-property' );
var objectKeys = require( '@stdlib/utils/keys' );
Expand Down Expand Up @@ -172,13 +174,10 @@
* @private
*/
function onRender() {
var args;
var i;
var args = [];
debug( 'Received a render event. Re-emitting...' );
args = new Array( arguments.length+1 );
args[ 0 ] = 'render';
for ( i = 0; i < arguments.length; i++ ) {
args[ i+1 ] = arguments[ i ];
for ( var i = 0; i < arguments.length; i++ ) {

Check failure on line 179 in lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

All 'var' declarations must be at the top of the function scope

Check failure on line 179 in lib/node_modules/@stdlib/plot/components/svg/symbols/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Move variable declaration to function body root
args.push(arguments[i]);
Comment on lines +179 to +180
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither of these lines follows project conventions.

}
self.emit.apply( self, args );
}
Expand Down
Loading