feat: refactor and add protocol support to `stats/base/nanmskmin` #6103

Kaushikgtm · 2025-03-16T21:19:34Z

Resolves #5663 .

Description

What is the purpose of this pull request?

This pull request:

{{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: refactor and add protocol support to stats/base/nanmskmin #5663

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

stdlib-bot · 2025-03-22T07:17:10Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/nanmskmin	$328 / 328$ $+ 100.00 %$	$42 / 42$ $+ 100.00 %$	$3 / 3$ $+ 100.00 %$	$328 / 328$ $+ 100.00 %$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

gururaj1512 · 2025-06-24T09:18:20Z

/stdlib update-copyright-years

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

Signed-off-by: Athan <kgryte@gmail.com>

kgryte

LGTM

Kaushikgtm added 12 commits March 17, 2025 02:18

Update benchmark.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

4d6af4e

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update benchmark.ndarray.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

afdfd7e

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update index.d.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

fa2341c

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

c52561c

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update index.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

fe95245

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Create accessors.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

7f0473a

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update nanmskmin.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

044a04d

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update ndarray.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

18082c5

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.nanmskmin.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

f99d8d4

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update test.ndarray.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

9c887ff

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

Update README.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

273ee7b

Signed-off-by: Kaushikgtm <162317291+Kaushikgtm@users.noreply.github.com>

stdlib-bot added Statistics Needs Review Good First PR labels Mar 16, 2025

Kaushikgtm added 15 commits March 17, 2025 03:00

Kaushikgtm added 8 commits March 22, 2025 15:03

Kaushikgtm closed this Mar 23, 2025

stdlib-bot removed the Needs Review label Mar 23, 2025

Kaushikgtm reopened this Mar 23, 2025

kgryte changed the title ~~feat: refactor and add protocol support to stats/base/nanmskmin #5663~~ feat: refactor and add protocol support to stats/base/nanmskmin Jun 8, 2025

kgryte requested a review from gururaj1512 June 8, 2025 08:59

stdlib-bot added the Needs Review label Jun 8, 2025

gururaj1512 and others added 2 commits June 24, 2025 12:45

gururaj1512 previously approved these changes Jun 24, 2025

View reviewed changes

stdlib-bot added the bot: In Progress label Jun 24, 2025

chore: update copyright years

Verified

This commit was signed with the committer’s verified signature.

stdlib-bot

GPG key ID: D53352F43F6FE3A4

Verified
Learn about vigilant mode

Loading
Loading status checks…

abcc902

stdlib-bot dismissed gururaj1512’s stale review via abcc902 June 24, 2025 09:19

stdlib-bot removed the bot: In Progress label Jun 24, 2025

gururaj1512 requested a review from kgryte June 24, 2025 10:16

kgryte removed the Needs Review label Jun 25, 2025

kgryte added 2 commits June 25, 2025 04:35

style: remove decimals

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

df7bc43

Signed-off-by: Athan <kgryte@gmail.com>

style: remove decimals

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

GPG key ID: B5690EEEBB952194

Verified
Learn about vigilant mode

Loading
Loading status checks…

0419e22

Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes Jun 25, 2025

View reviewed changes

kgryte merged commit 2a15634 into stdlib-js:develop Jun 25, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

Uh oh!

feat: refactor and add protocol support to `stats/base/nanmskmin` #6103

feat: refactor and add protocol support to `stats/base/nanmskmin` #6103

Kaushikgtm commented Mar 16, 2025 •

edited

Loading

Uh oh!

stdlib-bot commented Mar 22, 2025 •

edited

Loading

Uh oh!

gururaj1512 commented Jun 24, 2025

Uh oh!

kgryte left a comment

Uh oh!

Uh oh!

feat: refactor and add protocol support to stats/base/nanmskmin #6103

feat: refactor and add protocol support to stats/base/nanmskmin #6103

Conversation

Kaushikgtm commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stdlib-bot commented Mar 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gururaj1512 commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

feat: refactor and add protocol support to `stats/base/nanmskmin` #6103

feat: refactor and add protocol support to `stats/base/nanmskmin` #6103

Kaushikgtm commented Mar 16, 2025 •

edited

Loading

stdlib-bot commented Mar 22, 2025 •

edited

Loading