feat: add C implementation for math/base/special/aversin
#1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <[email protected]>
Planeshifter
added
Needs Review
Pranavchiku
suggested changes
Mar 6, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
Looks good, a minor change and it will be ready to merge.
Pranavchiku
added
Needs Changes
Pranavchiku
approved these changes
Mar 6, 2024
Member
Pranavchiku
left a comment
Pranavchiku
left a comment
There was a problem hiding this comment.
LGTM. Thanks @Snehil-Shah !
Pranavchiku
added
Feature
Planeshifter
approved these changes
Mar 6, 2024
bad-in-coding
pushed a commit
to bad-in-coding/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1731 Closes: stdlib-js#1721 --------- Signed-off-by: Snehil Shah <[email protected]> Co-authored-by: Pranavchiku <[email protected]> Reviewed-by: Pranavchiku <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
nishant-s7
pushed a commit
to nishant-s7/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1731 Closes: stdlib-js#1721 --------- Signed-off-by: Snehil Shah <[email protected]> Co-authored-by: Pranavchiku <[email protected]> Reviewed-by: Pranavchiku <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1721
Description
This pull request:
math/base/special/aversinRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers