Skip to content

chore: fix JavaScript lint errors (issue #10927)#10929

Merged
Planeshifter merged 2 commits intostdlib-js:developfrom
zamadye:fix-regex-flags
Mar 15, 2026
Merged

chore: fix JavaScript lint errors (issue #10927)#10929
Planeshifter merged 2 commits intostdlib-js:developfrom
zamadye:fix-regex-flags

Conversation

@zamadye
Copy link
Copy Markdown
Contributor

@zamadye zamadye commented Mar 14, 2026

Closes #10927

Description

What is the purpose of this pull request?

This pull request:

  • fix: correct regex flag order in linting (ig → gi)

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 14, 2026
@Lokeshranjan8
Copy link
Copy Markdown
Contributor

@zamadye thanks for the PR , but Could you please update the PR description to follow the required template? refer this PR description -#10896 (comment)

@zamadye
Copy link
Copy Markdown
Contributor Author

zamadye commented Mar 14, 2026

done! coba cek lagi

@zamadye
Copy link
Copy Markdown
Contributor Author

zamadye commented Mar 15, 2026

tried but tests are failing. any suggestions?

Copy link
Copy Markdown
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's land your first PR. 🎉

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 15, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 15, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Mar 15, 2026

PR Commit Message

chore: fix JavaScript lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/10929
Closes: https://github.com/stdlib-js/stdlib/issues/10927

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
utils/regexp-from-string $\color{green}95/95$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}95/95$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2026
@Planeshifter Planeshifter merged commit 0b7dd1b into stdlib-js:develop Mar 15, 2026
107 of 108 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Mar 15, 2026
@zamadye
Copy link
Copy Markdown
Contributor Author

zamadye commented Mar 15, 2026

tried adding tests but having issues. could you give more details?

@zamadye
Copy link
Copy Markdown
Contributor Author

zamadye commented Mar 15, 2026

sure, added test for that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

4 participants