Make stop operation async, add stop all operation #729
+174
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
async-stop
branch
2 times, most recently
from
571971c to
8798449
Compare
ChrisJBurns
previously approved these changes
Jun 16, 2025
This makes the stop operation asynchronous. The CLI calls it in a blocking manner, the API will stop the container in the background and return a 202 as soon as it has validated that the named container exists. As part of this change, add a stop all operation as requested for the UI project. This logic is exposed both as a CLI command and API endpoint.
ChrisJBurns
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the stop operation asynchronous. The CLI calls it in a blocking manner, the API will stop the container in the background and return a 202 as soon as it has validated that the named container exists.
As part of this change, add a stop all operation as requested for the UI project. This logic is exposed both as a CLI command and API endpoint.