Skip to content

Conversation

@markgoddard
Copy link
Contributor

Reverts #1075

There is an unresolved question about the behaviour of the alert rule when the denominator is zero.

@markgoddard markgoddard requested a review from a team as a code owner June 3, 2024 12:37
Copy link
Member

@seunghun1ee seunghun1ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that issue!
I'll open PR again once I address this issue.

@dougszumski
Copy link
Member

The original alert works as intended (comments on the original PR), so no need for this revert.

@markgoddard markgoddard deleted the revert-1075-monitor-swap-usage branch June 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants