Skip to content

Firewall config #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Oct 3, 2024
Merged

Firewall config #1016

merged 39 commits into from
Oct 3, 2024

Conversation

Alex-Welsh
Copy link
Member

Testing changes in CI because my AIO died.

@Alex-Welsh Alex-Welsh force-pushed the firewall-config branch 4 times, most recently from db400f7 to bfc290c Compare April 3, 2024 15:35
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a quick first pass. I think we need to consider whether these things are set by default or need to be opted into (like the LVM config). In the latter case we might provide some variables that can be referenced to enable the firewall config.

@Alex-Welsh
Copy link
Member Author

I've done a quick first pass. I think we need to consider whether these things are set by default or need to be opted into (like the LVM config). In the latter case we might provide some variables that can be referenced to enable the firewall config.

My opinion would be that we could disable it for Antelope and enable it for Caracal. I'll look into making a single bool to enable/disable all the rules at once.

@Alex-Welsh Alex-Welsh force-pushed the firewall-config branch 4 times, most recently from cc5e64b to 041fdef Compare April 15, 2024 15:54
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reno pls :)

@Alex-Welsh Alex-Welsh force-pushed the firewall-config branch 2 times, most recently from 6420f28 to c5398fc Compare April 16, 2024 10:32
@Alex-Welsh Alex-Welsh force-pushed the firewall-config branch 2 times, most recently from 249ab49 to 614853b Compare April 16, 2024 15:46
@Alex-Welsh Alex-Welsh force-pushed the firewall-config branch 2 times, most recently from 949c041 to 6892308 Compare April 30, 2024 12:01
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this in one deployment we saw an issue where seed/infra VM networking was blocked by the seed hypervisor firewall. We worked around it like this:

seed_hypervisor_sysctl_parameters:
  # By default this is 1, which causes layer 2 traffic flowing through Linux
  # bridges to pass through iptables. This blocks traffic from VMs (seed, wazuh) to
  # the Internet.
  net.bridge.bridge-nf-call-iptables: 0

This should be documented.

Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug only when firewalld is enabled

We are missing the firewall-cmd executable

Copy link
Contributor

@jovial jovial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked pretty nicely for me. I like the way that the rules take into account multiple group membership - really nice job. Lets get this in before it gets stale. It's disabled by default and we can iterate on it once it is.

I've made a jira to fix to the OVS AIO: INFRA-818

@Alex-Welsh Alex-Welsh merged commit f5ce941 into stackhpc/2023.1 Oct 3, 2024
12 checks passed
@Alex-Welsh Alex-Welsh deleted the firewall-config branch October 3, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants