[DEV-1039] Pull retag push fix #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g0rgamesh
force-pushed
the
pull-retag-push-fix
branch
from
a0fd78b to
c67354f
Compare
priteau
requested changes
Sep 9, 2022
g0rgamesh
force-pushed
the
pull-retag-push-fix
branch
2 times, most recently
from
0af7c59 to
38a1f79
Compare
g0rgamesh
force-pushed
the
pull-retag-push-fix
branch
from
38a1f79 to
d402279
Compare
priteau
approved these changes
Sep 9, 2022
markgoddard
reviewed
Sep 12, 2022
| @@ -80,24 +80,24 @@ | |||
| - name: Pull container images (may take a long time) | |||
| become: true | |||
| vars: | |||
| remote_image: "{% if docker_pull_registry != '' %}{{ docker_pull_registry }}/{% endif %}{{ docker_pull_namespace }}/{{ item }}:{{ docker_pull_tag }}" | |||
| remote_image: "{% if docker_pull_registry != '' %}{{ docker_pull_registry }}/{% endif %}{{ docker_pull_namespace }}/{{ item }}:{{ docker_pull_tag }}-{{ kolla_base_distro }}-{{ ansible_facts.distribution_release }}" | |||
There was a problem hiding this comment.
I don't think ansible_facts.distribution_release is always correct here. For example, on CentOS stream the image suffix is stream8.
There was a problem hiding this comment.
Would ansible_distribution_release be better?
There was a problem hiding this comment.
That's just a different way of accessing the same thing. Here's how kolla-ansible does it:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.