Skip to content

Conversation

@Soxasora
Copy link
Member

@Soxasora Soxasora commented Dec 19, 2025

Description

The editor initializes itself with appendValue (quote reply) if available, but doesn't keep track of appendValue changes, breaking quote reply on full items that already have the reply box open.

This PR fixes this via QuoteReplyPlugin that simply reacts to appendValue changes and replaces text content.

Additional Context

I didn't create an extension because appendValue, not being a stable prop, would have caused re-renders of the editor

Checklist

Are your changes backward compatible? Please answer below:

For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8, actually really good, got to use quote reply more

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:

Did you use AI for this? If so, how much did it assist you?


Note

Add QuoteReplyPlugin and plumb appendValue so the editor updates when the quote-reply content changes.

  • Editor:
    • Pass appendValue to EditorContent and initialize state with appendValue || text.value.
  • Plugins:
    • Add QuoteReplyPlugin that reacts to appendValue changes and reinitializes the editor state.
    • Wire QuoteReplyPlugin into the editor plugin stack.

Written by Cursor Bugbot for commit 5130c56. This will update automatically on new commits. Configure here.

@Soxasora
Copy link
Member Author

Editor initial state now uses only existing Formik text.value (no longer initializes with appendValue).

I mean we probably should initialize with appendValue anyway if it's present, to avoid flashes from text (if present)

@huumn
Copy link
Member

huumn commented Dec 19, 2025

First off, get some rest! You deserve it and this isn't super high priority.

I don't think this behavior is right. Every time I call quote reply it deletes anything I've already put in the text field. I think we want it to append the Value.

@Soxasora
Copy link
Member Author

Soxasora commented Dec 20, 2025

I thought about appending the Value too lol. But for some reason I also thought that it was meant to replace the whole editor.

I'll take some rest now, will switch to the native insertText tomorrow.

Copy link

@adlai adlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reading this as part of my gradual familiarising with the codebase;

and I wonder whether it would be possible, in some future patch, to insert the quoted lines at the cursor position, rather than appending ?

@Soxasora
Copy link
Member Author

I was thinking of implementing quote replies exactly like that. In absence of selection it will just append the content.

@Soxasora Soxasora marked this pull request as draft December 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants