Improved test failure message #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the failed statement and the backtrace.
|
That's unfortunate that they changed the formatting of the backtrack in Ruby 3.4. It'll be challenging to fix that matcher. |
In rube 3.4 the formatted backtrace does not use the backtick (`) but encloses the label with only single quotes.
That was surprisingly easy to fix. The "match" matcher takes care of evaluating against regex in the expected value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original test failure message only contained the assertion failure message which does not give a lot of information. Especially in larger test cases it can be difficult to find out which assertion failed. So I expanded the failure message to include all notification lines, which includes the assertion statement that failed and the relevant backtrace. The produced message is quite similar to the RSpec default message.
I adjusted the path of the backtrace to a file URI which VSCode would pick up and allow you to quickly jump the relevant line in the test. This however does not work yet when using VSCode while developing on WSL, I logged an issue with vscode for that. But at least this gives you the line number so you can manually navigate to it.