This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Add support for DROP VIEW #860
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
DROP VIEW
statements, as inAs each view in the statement may come from a different database, I have decided to model the plan as follows:
DropView
, that just contains a list of children of typeSingleDropView
.SingleDropView
implement theDatabaser
interface so the analyzer can resolve the database in each of them.The actual removal of the views happen in the
RowIter
fromDropView
, as we need to:DropView
can be deleted (i.e., they exist or they do not exist but the user has added theIF EXISTS
keyword to the statement)I first started implementing the removal in the
SingleDropView
nodes, but then it was difficult to check that all views could be deleted and then delete them, all in an atomic operation. The final implementation makes this easy with the newDeleteList
fromViewRegistry
.