Limit network image buffering to prevent OOM on oversized responses#2509
Open
XavLimSG wants to merge 1 commit intosquare:masterfrom
Open
Limit network image buffering to prevent OOM on oversized responses#2509XavLimSG wants to merge 1 commit intosquare:masterfrom
XavLimSG wants to merge 1 commit intosquare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the network decode path could buffer an arbitrarily large response body into memory on byte-array decode flows, which can
lead to OOM risk with oversized payloads.
I kept this change focused and minimal: I added a hard size guard for network responses and enforced the same limit in the decode path.
Root cause
On network requests, byte-array decode paths (
readByteArray()) did not enforce a maximum response size before loading data intomemory.
What I changed
50MB) inNetworkRequestHandlerbefore decode.BitmapUtils.decodeStream(...)for network decodes.BitmapUtils(readByteArrayWithLimit) and used it for:oversizedNetworkResponseThrowsAndClosesBodyContentLengthExceptionand response body is closed.Before / After