Support Spring Data container types for AuthorizeReturnObject #16953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
evgeniycheban
force-pushed
the
gh-15994
branch
6 times, most recently
from
aa991e6 to
fe6e014
Compare
jzheaux
added
in: data
jzheaux
reviewed
May 27, 2025
There was a problem hiding this comment.
Thanks, @evgeniycheban, this looks great. I left a comment that I could use your clarification on.
...ork/security/config/annotation/method/configuration/AuthorizationProxyDataConfiguration.java
Outdated
Show resolved
Hide resolved
jzheaux
added
the
status: waiting-for-feedback
jzheaux
requested changes
May 28, 2025
There was a problem hiding this comment.
Thanks, @evgeniycheban for the PR and for your comments. I've left my feedback inline.
...ork/security/config/annotation/method/configuration/AuthorizationProxyDataConfiguration.java
Outdated
Show resolved
Hide resolved
...ork/security/config/annotation/method/configuration/AuthorizationProxyDataConfiguration.java
Outdated
Show resolved
Hide resolved
jzheaux
changed the title
Closes spring-projectsgh-15994 Signed-off-by: Evgeniy Cheban <[email protected]>
|
@jzheaux I've updated the PR according to your feedback, thanks. |
spring-projects-issues
added
status: feedback-provided
jzheaux
approved these changes
May 29, 2025
|
Thanks, @evgeniycheban! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-15994