Altered the example in EmbeddedKafkaHolder usage #3929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests with an EmbeddedKafka instance are sometimes run in parallel in Junit. The current example is not thread safe, so I think the oficial documentation should account for that. Signed-off-by: mipo256 <[email protected]>
sobychacko
requested changes
May 28, 2025
| throw new KafkaException("Embedded broker failed to start", e); | ||
| } | ||
| started = true; | ||
| synchronized (this) { |
There was a problem hiding this comment.
this is fine. But, don't you think using a lock might be better here since synchronized may have issues with virtual threads?
There was a problem hiding this comment.
I think this is fully fine.
Just doc. Plus this is intended only for testing.
There is also a fix in Java 24 for synchronized and pinning from virtual threads: https://openjdk.org/jeps/491
There was a problem hiding this comment.
I agree with @artembilan. The synchronized block no longer pins the OS thread, so I do not think that is an issue
sobychacko
approved these changes
May 28, 2025
spring-builds
pushed a commit
that referenced
this pull request
May 28, 2025
Integration tests with an EmbeddedKafka instance are sometimes run in parallel in Junit. The current example is not thread safe, so I think the oficial documentation should account for that. Signed-off-by: mipo256 <[email protected]> (cherry picked from commit 579e7cb)
spring-builds
pushed a commit
that referenced
this pull request
May 28, 2025
Integration tests with an EmbeddedKafka instance are sometimes run in parallel in Junit. The current example is not thread safe, so I think the oficial documentation should account for that. Signed-off-by: mipo256 <[email protected]> (cherry picked from commit 579e7cb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests with an EmbeddedKafka instance are sometimes run in parallel in Junit. The current example is not thread safe, so I think the official documentation should account for that.